Discussion:
[Kde-accessibility] Review Request 116634: Avoid MAXPATHLEN
Maximiliano Curia
2014-03-06 15:01:50 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116634/
-----------------------------------------------------------

Review request for KDE Accessibility.


Repository: jovie


Description
-------

Hi,

MAXPATHLEN is not defined in system that have no inherent limit, such as in hurd. This patch uses the POSIX.1-2008 definition of realpath to circumvent this.


Diffs
-----

libkttsd/filterconf.cpp cc91ed5eb978fb5d9d2941717cb1c49181762490

Diff: https://git.reviewboard.kde.org/r/116634/diff/


Testing
-------


Thanks,

Maximiliano Curia
Frederik Gladhorn
2014-03-08 16:57:35 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116634/#review52403
-----------------------------------------------------------

Ship it!


Ship It!

- Frederik Gladhorn
Post by Maximiliano Curia
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/116634/
-----------------------------------------------------------
(Updated March 6, 2014, 3:01 p.m.)
Review request for KDE Accessibility.
Repository: jovie
Description
-------
Hi,
MAXPATHLEN is not defined in system that have no inherent limit, such as in hurd. This patch uses the POSIX.1-2008 definition of realpath to circumvent this.
Diffs
-----
libkttsd/filterconf.cpp cc91ed5eb978fb5d9d2941717cb1c49181762490
Diff: https://git.reviewboard.kde.org/r/116634/diff/
Testing
-------
Thanks,
Maximiliano Curia
Maximiliano Curia
2014-03-14 17:32:52 UTC
Permalink
Post by Maximiliano Curia
Post by Frederik Gladhorn
Ship It!
Hi

I don't have commit access, can you commit the change?

Thanks.


- Maximiliano


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116634/#review52403
-----------------------------------------------------------
Post by Maximiliano Curia
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/116634/
-----------------------------------------------------------
(Updated March 6, 2014, 3:01 p.m.)
Review request for KDE Accessibility.
Repository: jovie
Description
-------
Hi,
MAXPATHLEN is not defined in system that have no inherent limit, such as in hurd. This patch uses the POSIX.1-2008 definition of realpath to circumvent this.
Diffs
-----
libkttsd/filterconf.cpp cc91ed5eb978fb5d9d2941717cb1c49181762490
Diff: https://git.reviewboard.kde.org/r/116634/diff/
Testing
-------
Thanks,
Maximiliano Curia
Commit Hook
2014-03-15 11:12:49 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116634/#review52968
-----------------------------------------------------------


This review has been submitted with commit 02d9fbe64b07390be506c8005dc6837b603992d6 by Frederik Gladhorn to branch master.

- Commit Hook
Post by Maximiliano Curia
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/116634/
-----------------------------------------------------------
(Updated March 6, 2014, 3:01 p.m.)
Review request for KDE Accessibility.
Repository: jovie
Description
-------
Hi,
MAXPATHLEN is not defined in system that have no inherent limit, such as in hurd. This patch uses the POSIX.1-2008 definition of realpath to circumvent this.
Diffs
-----
libkttsd/filterconf.cpp cc91ed5eb978fb5d9d2941717cb1c49181762490
Diff: https://git.reviewboard.kde.org/r/116634/diff/
Testing
-------
Thanks,
Maximiliano Curia
Maximiliano Curia
2014-03-15 11:12:49 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116634/
-----------------------------------------------------------

(Updated March 15, 2014, 11:12 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Accessibility.


Repository: jovie


Description
-------

Hi,

MAXPATHLEN is not defined in system that have no inherent limit, such as in hurd. This patch uses the POSIX.1-2008 definition of realpath to circumvent this.


Diffs
-----

libkttsd/filterconf.cpp cc91ed5eb978fb5d9d2941717cb1c49181762490

Diff: https://git.reviewboard.kde.org/r/116634/diff/


Testing
-------


Thanks,

Maximiliano Curia

Loading...