Discussion:
[Kde-accessibility] Review Request 126483: Use SHARE_INSTALL_PREFIX to install appstream data
Heiko Becker
2015-12-23 11:35:06 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126483/
-----------------------------------------------------------

Review request for KDE Accessibility and Jeremy Whiting.


Repository: jovie


Description
-------

...instead of hard-coding share/.. which is not helpful on a multiarch
layout, where the prefix might be something like /usr/${arch} but arch
independent files should still go into /usr/share.


Diffs
-----

jovie/CMakeLists.txt 66b25f7

Diff: https://git.reviewboard.kde.org/r/126483/diff/


Testing
-------

jovie.appdata.xml gets installed into the desired location.


Thanks,

Heiko Becker
Rex Dieter
2015-12-23 14:52:35 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126483/#review89997
-----------------------------------------------------------

Ship it!


+1, that's the convention most other kde modules use.

- Rex Dieter
Post by Heiko Becker
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/126483/
-----------------------------------------------------------
(Updated Dec. 23, 2015, 11:35 a.m.)
Review request for KDE Accessibility and Jeremy Whiting.
Repository: jovie
Description
-------
...instead of hard-coding share/.. which is not helpful on a multiarch
layout, where the prefix might be something like /usr/${arch} but arch
independent files should still go into /usr/share.
Diffs
-----
jovie/CMakeLists.txt 66b25f7
Diff: https://git.reviewboard.kde.org/r/126483/diff/
Testing
-------
jovie.appdata.xml gets installed into the desired location.
Thanks,
Heiko Becker
Jeremy Whiting
2015-12-23 17:08:14 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126483/#review90010
-----------------------------------------------------------

Ship it!


Ship It!

- Jeremy Whiting
Post by Heiko Becker
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/126483/
-----------------------------------------------------------
(Updated Dec. 23, 2015, 4:35 a.m.)
Review request for KDE Accessibility and Jeremy Whiting.
Repository: jovie
Description
-------
...instead of hard-coding share/.. which is not helpful on a multiarch
layout, where the prefix might be something like /usr/${arch} but arch
independent files should still go into /usr/share.
Diffs
-----
jovie/CMakeLists.txt 66b25f7
Diff: https://git.reviewboard.kde.org/r/126483/diff/
Testing
-------
jovie.appdata.xml gets installed into the desired location.
Thanks,
Heiko Becker
Heiko Becker
2015-12-23 17:37:02 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126483/
-----------------------------------------------------------

(Updated Dec. 23, 2015, 5:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Accessibility and Jeremy Whiting.


Changes
-------

Submitted with commit 510ad3a839bcb5836335dd52c9936e8f4f2849e7 by Heiko Becker to branch Applications/15.12.


Repository: jovie


Description
-------

...instead of hard-coding share/.. which is not helpful on a multiarch
layout, where the prefix might be something like /usr/${arch} but arch
independent files should still go into /usr/share.


Diffs
-----

jovie/CMakeLists.txt 66b25f7

Diff: https://git.reviewboard.kde.org/r/126483/diff/


Testing
-------

jovie.appdata.xml gets installed into the desired location.


Thanks,

Heiko Becker

Loading...