[Kde-accessibility] Review Request 125042: Fix top buttons (close button, hide numpad button)

[Fredrick Brennan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------

Review request for KDE Accessibility.


Repository: kvkbd


Description
-------

Fix top buttons (close button, hide numpad button)


Diffs
-----

src/kbddock.cpp 4800022
src/kbdtray.cpp a9cf135
src/kvkbdapp.h 498f842
src/kvkbdapp.cpp 825979a
src/main.cpp 49ba346
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead

Diff: https://git.reviewboard.kde.org/r/125042/diff/


Testing
-------

Hello,

The top buttons of kvkbd weren't working properly on

* Qt: 4.8.7
* KDE Development Platform: 4.14.11

No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.

This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.


Thanks,

Fredrick Brennan

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/#review84813
-----------------------------------------------------------



src/kbdtray.cpp (line 42)
<https://git.reviewboard.kde.org/r/125042/#comment58692>

Add i18n("....")



src/kvkbdapp.h (line 38)
<https://git.reviewboard.kde.org/r/125042/#comment58693>

Why remove uniqueapplication ?



src/kvkbdapp.cpp (line 421)
<https://git.reviewboard.kde.org/r/125042/#comment58694>

showGroup != "hideWhen..."



src/kvkbdapp.cpp (line 431)
<https://git.reviewboard.kde.org/r/125042/#comment58695>

Remove this->



src/kvkbdapp.cpp (line 434)
<https://git.reviewboard.kde.org/r/125042/#comment58696>

if (showGroup != ...")


- Laurent Montel

Post by Fredrick Brennan
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------
(Updated sep. 4, 2015, 9:54 matin)
Review request for KDE Accessibility.
Repository: kvkbd
Description
-------
Fix top buttons (close button, hide numpad button)
Diffs
-----
src/kbddock.cpp 4800022
src/kbdtray.cpp a9cf135
src/kvkbdapp.h 498f842
src/kvkbdapp.cpp 825979a
src/main.cpp 49ba346
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead
Diff: https://git.reviewboard.kde.org/r/125042/diff/
Testing
-------
Hello,
The top buttons of kvkbd weren't working properly on
* Qt: 4.8.7
* KDE Development Platform: 4.14.11
No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.
This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.
Thanks,
Fredrick Brennan

[Fredrick Brennan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------

(Updated Sept. 4, 2015, 10:41 a.m.)


Review request for KDE Accessibility.


Repository: kvkbd


Description
-------

Fix top buttons (close button, hide numpad button)


Diffs (updated)
-----

src/kbddock.cpp 4800022
src/kbdtray.cpp a9cf135
src/kvkbdapp.h 498f842
src/kvkbdapp.cpp 825979a
src/main.cpp 49ba346
src/mainwidget.cpp 5db552e
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead

Diff: https://git.reviewboard.kde.org/r/125042/diff/


Testing
-------

Hello,

The top buttons of kvkbd weren't working properly on

* Qt: 4.8.7
* KDE Development Platform: 4.14.11

No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.

This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.


Thanks,

Fredrick Brennan

[Fredrick Brennan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------

(Updated Sept. 4, 2015, 10:55 a.m.)


Review request for KDE Accessibility.


Changes
-------

Change back to KUniqueApplication


Repository: kvkbd


Description
-------

Fix top buttons (close button, hide numpad button)


Diffs (updated)
-----

src/main.cpp 49ba346
src/kvkbdapp.cpp 825979a
src/kvkbdapp.h 498f842
src/kbdtray.cpp a9cf135
src/kbddock.cpp 4800022
src/mainwidget.cpp 5db552e
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead

Diff: https://git.reviewboard.kde.org/r/125042/diff/


Testing
-------

Hello,

The top buttons of kvkbd weren't working properly on

* Qt: 4.8.7
* KDE Development Platform: 4.14.11

No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.

This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.


Thanks,

Fredrick Brennan

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/#review84815
-----------------------------------------------------------



src/kvkbdapp.cpp (line 415)
<https://git.reviewboard.kde.org/r/125042/#comment58699>

Use QMap<...>::ConstIterator

and
QMap<...>::ConstIterator end(actionButtons.end())
=> optimization.

for(i = ...; i != end; ++i)


- Laurent Montel

Post by Fredrick Brennan
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------
(Updated sep. 4, 2015, 10:55 matin)
Review request for KDE Accessibility.
Repository: kvkbd
Description
-------
Fix top buttons (close button, hide numpad button)
Diffs
-----
src/main.cpp 49ba346
src/kvkbdapp.cpp 825979a
src/kvkbdapp.h 498f842
src/kbdtray.cpp a9cf135
src/kbddock.cpp 4800022
src/mainwidget.cpp 5db552e
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead
Diff: https://git.reviewboard.kde.org/r/125042/diff/
Testing
-------
Hello,
The top buttons of kvkbd weren't working properly on
* Qt: 4.8.7
* KDE Development Platform: 4.14.11
No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.
This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.
Thanks,
Fredrick Brennan

[Fredrick Brennan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------

(Updated Sept. 4, 2015, 11:48 a.m.)


Review request for KDE Accessibility.


Changes
-------

Use ConstIterator instead of regular iterator, close issue


Repository: kvkbd


Description
-------

Fix top buttons (close button, hide numpad button)


Diffs (updated)
-----

src/main.cpp 49ba346
src/kvkbdapp.cpp 825979a
src/kvkbdapp.h 498f842
src/kbdtray.cpp a9cf135
src/kbddock.cpp 4800022
src/mainwidget.cpp 5db552e
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead

Diff: https://git.reviewboard.kde.org/r/125042/diff/


Testing
-------

Hello,

The top buttons of kvkbd weren't working properly on

* Qt: 4.8.7
* KDE Development Platform: 4.14.11

No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.

This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.


Thanks,

Fredrick Brennan

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/#review84818
-----------------------------------------------------------


For me seems good.
But we need to have review from maintainer.
Regards

- Laurent Montel

Post by Fredrick Brennan
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------
(Updated sep. 4, 2015, 11:48 matin)
Review request for KDE Accessibility.
Repository: kvkbd
Description
-------
Fix top buttons (close button, hide numpad button)
Diffs
-----
src/main.cpp 49ba346
src/kvkbdapp.cpp 825979a
src/kvkbdapp.h 498f842
src/kbdtray.cpp a9cf135
src/kbddock.cpp 4800022
src/mainwidget.cpp 5db552e
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead
Diff: https://git.reviewboard.kde.org/r/125042/diff/
Testing
-------
Hello,
The top buttons of kvkbd weren't working properly on
* Qt: 4.8.7
* KDE Development Platform: 4.14.11
No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.
This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.
Thanks,
Fredrick Brennan

[Fredrick Brennan]

Post by Fredrick Brennan

Post by Laurent Montel
For me seems good.
But we need to have review from maintainer.
Regards

Hello Mr. Montel...

I actually submitted these patches because I think the project is abandoned.

If the maintainer is still active, it's good, so I will wait 2 weeks before bringing it up again.

If not, I am interested in maintaining the KDE Virtual Keyboard project and bringing it into QT5.

I have a severe disability and make use of this specific software often. It will be a big inconvenience for me, and perhaps all the disabled KDE users out there who can't or won't speak up, if it becomes abandoned and does not ship in KDE5 and is dropped from repositories.

I have a good understanding of assistive technology, and have much programming experience so can learn anything about Qt I don't know.

Thank you. I added to my calendar to make sure I check this thread again in 2 weeks. If no reply from maintainer we should talk more then. :)


- Fredrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/#review84818
-----------------------------------------------------------

Post by Fredrick Brennan
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 11:48 a.m.)
Review request for KDE Accessibility.
Repository: kvkbd
Description
-------
Fix top buttons (close button, hide numpad button)
Diffs
-----
src/main.cpp 49ba346
src/kvkbdapp.cpp 825979a
src/kvkbdapp.h 498f842
src/kbdtray.cpp a9cf135
src/kbddock.cpp 4800022
src/mainwidget.cpp 5db552e
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead
Diff: https://git.reviewboard.kde.org/r/125042/diff/
Testing
-------
Hello,
The top buttons of kvkbd weren't working properly on
* Qt: 4.8.7
* KDE Development Platform: 4.14.11
No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.
This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.
Thanks,
Fredrick Brennan

[Laurent Montel]

Post by Fredrick Brennan

Post by Laurent Montel
For me seems good.
But we need to have review from maintainer.
Regards

Hello Mr. Montel...
I actually submitted these patches because I think the project is abandoned.
If the maintainer is still active, it's good, so I will wait 2 weeks before bringing it up again.
If not, I am interested in maintaining the KDE Virtual Keyboard project and bringing it into QT5.
I have a severe disability and make use of this specific software often. It will be a big inconvenience for me, and perhaps all the disabled KDE users out there who can't or won't speak up, if it becomes abandoned and does not ship in KDE5 and is dropped from repositories.
I have a good understanding of assistive technology, and have much programming experience so can learn anything about Qt I don't know.
Thank you. I added to my calendar to make sure I check this thread again in 2 weeks. If no reply from maintainer we should talk more then. :)

For me indeed it's good to wait an answer from previous maintainer.
Did you send him an email ?


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/#review84818
-----------------------------------------------------------

Post by Fredrick Brennan
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------
(Updated sep. 4, 2015, 11:48 matin)
Review request for KDE Accessibility.
Repository: kvkbd
Description
-------
Fix top buttons (close button, hide numpad button)
Diffs
-----
src/main.cpp 49ba346
src/kvkbdapp.cpp 825979a
src/kvkbdapp.h 498f842
src/kbdtray.cpp a9cf135
src/kbddock.cpp 4800022
src/mainwidget.cpp 5db552e
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead
Diff: https://git.reviewboard.kde.org/r/125042/diff/
Testing
-------
Hello,
The top buttons of kvkbd weren't working properly on
* Qt: 4.8.7
* KDE Development Platform: 4.14.11
No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.
This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.
Thanks,
Fredrick Brennan

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/#review84836
-----------------------------------------------------------

Ship it!


I think since the author hasn't made a commit in over a year and it's in playground anyway, this should be good to go in my opinion.

- Jeremy Whiting

Post by Fredrick Brennan
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 5:48 a.m.)
Review request for KDE Accessibility.
Repository: kvkbd
Description
-------
Fix top buttons (close button, hide numpad button)
Diffs
-----
src/main.cpp 49ba346
src/kvkbdapp.cpp 825979a
src/kvkbdapp.h 498f842
src/kbdtray.cpp a9cf135
src/kbddock.cpp 4800022
src/mainwidget.cpp 5db552e
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead
Diff: https://git.reviewboard.kde.org/r/125042/diff/
Testing
-------
Hello,
The top buttons of kvkbd weren't working properly on
* Qt: 4.8.7
* KDE Development Platform: 4.14.11
No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.
This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.
Thanks,
Fredrick Brennan

[Fredrick Brennan]

Post by Fredrick Brennan

Post by Jeremy Whiting
I think since the author hasn't made a commit in over a year and it's in playground anyway, this should be good to go in my opinion.

Cool :D What do you think of comment to Montel post above?


- Fredrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/#review84836
-----------------------------------------------------------

Post by Fredrick Brennan
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 11:48 a.m.)
Review request for KDE Accessibility.
Repository: kvkbd
Description
-------
Fix top buttons (close button, hide numpad button)
Diffs
-----
src/main.cpp 49ba346
src/kvkbdapp.cpp 825979a
src/kvkbdapp.h 498f842
src/kbdtray.cpp a9cf135
src/kbddock.cpp 4800022
src/mainwidget.cpp 5db552e
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead
Diff: https://git.reviewboard.kde.org/r/125042/diff/
Testing
-------
Hello,
The top buttons of kvkbd weren't working properly on
* Qt: 4.8.7
* KDE Development Platform: 4.14.11
No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.
This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.
Thanks,
Fredrick Brennan

[Albert Astals Cid]

Post by Fredrick Brennan

Post by Jeremy Whiting
I think since the author hasn't made a commit in over a year and it's in playground anyway, this should be good to go in my opinion.

Cool :D What do you think of comment to Montel post above?

I am very sorry this was dropped.

If you need this application you should really try to port it to Qt5.

Do you need help with something?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/#review84836
-----------------------------------------------------------

Post by Fredrick Brennan
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125042/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 11:48 a.m.)
Review request for KDE Accessibility.
Repository: kvkbd
Description
-------
Fix top buttons (close button, hide numpad button)
Diffs
-----
src/kbddock.cpp 4800022
src/kbdtray.cpp a9cf135
src/kvkbdapp.h 498f842
src/kvkbdapp.cpp 825979a
src/main.cpp 49ba346
src/mainwidget.cpp 5db552e
src/standart.xml 7b66c89
src/themeloader.cpp f3d8e60
src/vbutton.cpp 7f7cead
Diff: https://git.reviewboard.kde.org/r/125042/diff/
Testing
-------
Hello,
The top buttons of kvkbd weren't working properly on
* Qt: 4.8.7
* KDE Development Platform: 4.14.11
No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.
This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.
Thanks,
Fredrick Brennan