[Kde-accessibility] Review Request 122635: Port from Q3ButtonGroup to QButtonGroup.

Discussion:

Jeremy Whiting

2015-02-19 01:36:44 UTC

Permalink

Jeremy Whiting

2015-02-19 01:37:37 UTC

Permalink

Jeremy Whiting

2015-02-20 17:59:48 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122635/
-----------------------------------------------------------

(Updated Feb. 20, 2015, 10:59 a.m.)

Review request for KDE Accessibility.

Changes
-------

Also port from KProgressDialog to QProgressDialog and move all ui.rc files to the top level in git and to the same CMakeLists.txt file.

Summary (updated)
-----------------

Start porting away from Qt3Support classes.

Repository: kmouth

Description (updated)
-------

Port from Q3ButtonGroup to QButtonGroup.
Port from KProgressDialog to QProgressDialog.
Move phrasebookui.rc to top level and install from main CMakeLists.txt

Diffs (updated)
-----

CMakeLists.txt 56fb3a045604ff8482b7faf8dd456e79abb4ab6b
kmouth.cpp 319cfb8992ef146c0115861a1a9a271cadf01ecc
phrasebook/CMakeLists.txt 55360a9c93b604115a99881534e37209dde79b4c
phrasebook/phrasebookdialog.h f97b269b0f0b94962a0a2f1a5e68a3a13c35376b
phrasebook/phrasebookdialog.cpp 13b52d79601437e957d592f01f97785681dabf32
phrasebook/phrasebookdialogui.rc
wordcompletion/dictionarycreationwizard.cpp b26fd20f2cbec65da5a11ec15f22895f4bc222be
wordcompletion/wordlist.h 0c582b722a10fb43a7f85539f1f0b61fd4df67a3
wordcompletion/wordlist.cpp 6fc18e0c27c9557ae78bb2c764499c6f009b379b

Diff: https://git.reviewboard.kde.org/r/122635/diff/

Testing
-------

It still builds and runs.

Thanks,

Jeremy Whiting

Jeremy Whiting

2015-02-23 00:39:49 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122635/
-----------------------------------------------------------

(Updated Feb. 22, 2015, 5:39 p.m.)

Review request for KDE Accessibility.

Changes
-------

Added porting from K3Wizard to QWizard.

Summary (updated)
-----------------

Start migrating away from Qt3Support classes.

Repository: kmouth

Description (updated)
-------

Start migrating away from Qt3Support classes.

Port from Q3ButtonGroup to QButtonGroup.
Port from KProgressDialog to QProgressDialog.
Move phrasebookui.rc to top level and install from main CMakeLists.txt
Port from K3Wizard to QWizard.
Changed QWidgets to QWizardPage and made CreationSourceWidget control
which page to go to next based on what is selected.

Diffs (updated)
-----

CMakeLists.txt 56fb3a045604ff8482b7faf8dd456e79abb4ab6b
kmouth.cpp 319cfb8992ef146c0115861a1a9a271cadf01ecc
phrasebook/CMakeLists.txt 55360a9c93b604115a99881534e37209dde79b4c
phrasebook/phrasebookdialog.h f97b269b0f0b94962a0a2f1a5e68a3a13c35376b
phrasebook/phrasebookdialog.cpp 13b52d79601437e957d592f01f97785681dabf32
phrasebook/phrasebookdialogui.rc
wordcompletion/dictionarycreationwizard.h 6aee2ec15c1849fad0938dbc9f37fa66de13aa2d
wordcompletion/dictionarycreationwizard.cpp b26fd20f2cbec65da5a11ec15f22895f4bc222be
wordcompletion/wordlist.h 0c582b722a10fb43a7f85539f1f0b61fd4df67a3
wordcompletion/wordlist.cpp 6fc18e0c27c9557ae78bb2c764499c6f009b379b

Diff: https://git.reviewboard.kde.org/r/122635/diff/

Testing
-------

It still builds and runs.

Thanks,

Jeremy Whiting

Jeremy Whiting

2015-05-06 19:05:09 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122635/
-----------------------------------------------------------

(Updated May 6, 2015, 1:05 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Accessibility.

Repository: kmouth

Description
-------

Start migrating away from Qt3Support classes.

Port from Q3ButtonGroup to QButtonGroup.
Port from KProgressDialog to QProgressDialog.
Move phrasebookui.rc to top level and install from main CMakeLists.txt
Port from K3Wizard to QWizard.
Changed QWidgets to QWizardPage and made CreationSourceWidget control
which page to go to next based on what is selected.

Diffs
-----

CMakeLists.txt 56fb3a045604ff8482b7faf8dd456e79abb4ab6b
kmouth.cpp 319cfb8992ef146c0115861a1a9a271cadf01ecc
phrasebook/CMakeLists.txt 55360a9c93b604115a99881534e37209dde79b4c
phrasebook/phrasebookdialog.h f97b269b0f0b94962a0a2f1a5e68a3a13c35376b
phrasebook/phrasebookdialog.cpp 13b52d79601437e957d592f01f97785681dabf32
phrasebook/phrasebookdialogui.rc
wordcompletion/dictionarycreationwizard.h 6aee2ec15c1849fad0938dbc9f37fa66de13aa2d
wordcompletion/dictionarycreationwizard.cpp b26fd20f2cbec65da5a11ec15f22895f4bc222be
wordcompletion/wordlist.h 0c582b722a10fb43a7f85539f1f0b61fd4df67a3
wordcompletion/wordlist.cpp 6fc18e0c27c9557ae78bb2c764499c6f009b379b

Diff: https://git.reviewboard.kde.org/r/122635/diff/

Testing
-------

It still builds and runs.

Thanks,

Jeremy Whiting