Jeremy Whiting
2014-03-06 06:04:12 UTC
Took a quick read through that just now and it looks pretty promising
from what I saw. I guess I don't know my way around gerrit very well
because I couldn't see a place to comment on the code like
reviewboard.
Really the only difference between jovie and that class are the following:
1. jovie has some old code and ui to control jobs at a fine grain that
spd doesn't expose really well, so I left it out when I ported ktts to
spd.
2. user defined filters with some sane/useful defaults (if we were to
use QtSpeech for kde notifications, set konvi to speak all messages,
there's not a way to let the user say change "<jpwhiting> fregl: you
rock" into "jpwhiting says fregl you rock")
3. user configurability (As a user I can't set up which voice I would
like all speech-using applications to use)
4. dbus, though this isn't as important if each application that uses
speech links to the library and speech-dispatcher or the system apis
do the async for us already anyway as you said.
Items 1 and 4 will be irrelevant in a KF5 world but I'm wondering how
2 and 3 could be added either to qtspeech itself or as a kspeech
library that wraps qtspeech for kde applications to use.
Any thoughts on that? I would be pretty interested in helping with
qtspeech if it greatly simplifies or even deprecates jovie as it looks
like it could do possibly.
Jeremy
It's a regular Qt module providing a library that currently consists of one
class.
It is currently quite incomplete because it lacks voice/language
configuration.
On the up side, I implemented basic backends for win/mac/android/linux.
Linux is using speech-dispatcher, but I was quite dissatisfied with spd's
API. For example it lacks proper free functions for the structs it allocates
- so one has to basically leak them.
I didn't dare looking at Jovie/kttsd since I used the Qt license.
Greetings,
Frederik
Kde-frameworks-devel mailing list
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
from what I saw. I guess I don't know my way around gerrit very well
because I couldn't see a place to comment on the code like
reviewboard.
Really the only difference between jovie and that class are the following:
1. jovie has some old code and ui to control jobs at a fine grain that
spd doesn't expose really well, so I left it out when I ported ktts to
spd.
2. user defined filters with some sane/useful defaults (if we were to
use QtSpeech for kde notifications, set konvi to speak all messages,
there's not a way to let the user say change "<jpwhiting> fregl: you
rock" into "jpwhiting says fregl you rock")
3. user configurability (As a user I can't set up which voice I would
like all speech-using applications to use)
4. dbus, though this isn't as important if each application that uses
speech links to the library and speech-dispatcher or the system apis
do the async for us already anyway as you said.
Items 1 and 4 will be irrelevant in a KF5 world but I'm wondering how
2 and 3 could be added either to qtspeech itself or as a kspeech
library that wraps qtspeech for kde applications to use.
Any thoughts on that? I would be pretty interested in helping with
qtspeech if it greatly simplifies or even deprecates jovie as it looks
like it could do possibly.
Jeremy
Hello all, I've realized a bit ago that kspeech was not included in
the kdelibs split (probably because it was in staging at the time and
didn't conform to the other framework policies yet). I've cleaned it
up a bit and put it in my scratch space, but have some architectural
questions about it before I make it a proper framework.
1. The KSpeech dbus interface is old and showing its age. Many of the
methods are no longer implemented in the application itself since it
was ported to speech-dispatcher. One thing I would definitely like to
do is clean up/remove methods that aren't implemented currently (and
possibly re add some later on if speech-dispatcher gets better/more
support for job control, etc.) So the question about this is is KF5
time a good time to drop/clean up the dbus interface?
2. The KSpeech interface that was in kdelibs/interfaces is just that a
dbus interface only. I would like to make it a proper
library/framework with a QObject based class for talking to Jovie (the
application that implements the KSpeech dbus interface) and wonder if
other things such as what's currently in jovie/libkttsd should be in
the kspeech library also. If I move code from jovie into libkspeech
(or merge kspeech interface into libkttsd and make libkttsd a
framework likely renamed to libkspeech since libkttsd isn't a public
library anyway and has the old ktts name) what's the best way to
preserve the history of both the kspeech interface and libkttsd
sources. Didn't the plasma or kde-workspaces split do something fancy
with git where old history pointed to the old git repo somehow?
Along with this, if libkspeech is defining the kspeech dbus interface
and has a class to talk to that interface, does the interface still
need to be in servicetypes like the dbustexttospeech.desktop file that
was installed in /usr/share/kde4/servicetypes in kde4 times?
https://codereview.qt-project.org/#admin,project,qt/qtspeech,infothe kdelibs split (probably because it was in staging at the time and
didn't conform to the other framework policies yet). I've cleaned it
up a bit and put it in my scratch space, but have some architectural
questions about it before I make it a proper framework.
1. The KSpeech dbus interface is old and showing its age. Many of the
methods are no longer implemented in the application itself since it
was ported to speech-dispatcher. One thing I would definitely like to
do is clean up/remove methods that aren't implemented currently (and
possibly re add some later on if speech-dispatcher gets better/more
support for job control, etc.) So the question about this is is KF5
time a good time to drop/clean up the dbus interface?
2. The KSpeech interface that was in kdelibs/interfaces is just that a
dbus interface only. I would like to make it a proper
library/framework with a QObject based class for talking to Jovie (the
application that implements the KSpeech dbus interface) and wonder if
other things such as what's currently in jovie/libkttsd should be in
the kspeech library also. If I move code from jovie into libkspeech
(or merge kspeech interface into libkttsd and make libkttsd a
framework likely renamed to libkspeech since libkttsd isn't a public
library anyway and has the old ktts name) what's the best way to
preserve the history of both the kspeech interface and libkttsd
sources. Didn't the plasma or kde-workspaces split do something fancy
with git where old history pointed to the old git repo somehow?
Along with this, if libkspeech is defining the kspeech dbus interface
and has a class to talk to that interface, does the interface still
need to be in servicetypes like the dbustexttospeech.desktop file that
was installed in /usr/share/kde4/servicetypes in kde4 times?
It's a regular Qt module providing a library that currently consists of one
class.
It is currently quite incomplete because it lacks voice/language
configuration.
On the up side, I implemented basic backends for win/mac/android/linux.
Linux is using speech-dispatcher, but I was quite dissatisfied with spd's
API. For example it lacks proper free functions for the structs it allocates
- so one has to basically leak them.
I didn't dare looking at Jovie/kttsd since I used the Qt license.
Greetings,
Frederik
thanks,
Jeremy
_______________________________________________
Kde-frameworks-devel mailing list
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
_______________________________________________Jeremy
_______________________________________________
Kde-frameworks-devel mailing list
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Kde-frameworks-devel mailing list
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel